Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using powershell as windows interpreter #379

Merged
merged 22 commits into from
Jan 21, 2021

Conversation

vinferrer
Copy link
Collaborator

@vinferrer vinferrer commented Jan 21, 2021

Closes Nothing

I realised that even though the windows tests were passing, there where errors with pip that should trigger the failure. After speaking with the cirrus support (cirruslabs/cirrus-ci-docs#765) we realised that using powershell was the problem. Therefore I proposed to apply this tiny changes to the windows tests so they work and trigger failure when something breaks.

Proposed Changes

  • Stop using powershell as windows interpreter
  • Migrate some libraries installation to the docker build ( numpy matplotlib Cython PyYAML h5py scipy)
  • Sorry for not adding this to the previous PR

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@vinferrer vinferrer changed the title Windows fail Stop using powershell as windows interpreter Jan 21, 2021
@vinferrer vinferrer requested a review from eurunuela January 21, 2021 12:52
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #379 (b575a24) into master (ac0096b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files           8        8           
  Lines         839      839           
=======================================
  Hits          794      794           
  Misses         45       45           

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinferrer vinferrer merged commit 7915476 into physiopy:master Jan 21, 2021
@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia smoia added the released This issue/pull request has been released. label Jan 21, 2021
@smoia smoia added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Jan 21, 2021
@smoia smoia assigned vinferrer and unassigned eurunuela Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants