-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .mailmap to improve git shortlog -sn
output
#378
Conversation
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 94.61% 94.61%
=======================================
Files 8 8
Lines 836 836
=======================================
Hits 791 791
Misses 45 45 |
Hello @yarikoptic ! Thank you for the proposal! I don't think there's a major issue in adding .mailmap. Do you have any specific use in mind though? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks completely fine to me, could I ask you to add @danalclop to this list before merging? I noticed that in the shortlog of this PR he appears both as Daniel Alcala' and as Daniel Alcala' Lopez
git shortlog -sn
output
|
ef2c983
to
4d5c347
Compare
added, force-pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
And I think I can merge it in without waiting for a second review
🚀 PR was released in |
.mailmap is mechanism to properly account for contributors using different git configuration "ids".
output on master master
output on this PR
Change Type
bugfix
(+0.0.1)minor
(+0.1.0)major
(+1.0.0)refactoring
(no version update)test
(no version update)infrastructure
(no version update)documentation
(no version update)other
Checklist before review