Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate testing to Cirrus CI #375

Merged
merged 290 commits into from
Jan 19, 2021
Merged

Migrate testing to Cirrus CI #375

merged 290 commits into from
Jan 19, 2021

Conversation

vinferrer
Copy link
Collaborator

@vinferrer vinferrer commented Jan 4, 2021

Closes #373
Closes #354
Closes #353

Proposed Changes

  • Adapts all the tests from Circle CI to Cirrus CI
  • Implements the matrix configuration to makeenv, unittest and integration tasks to simplify the code.
  • This CI uses the codecov bash uploader. Reading the docs in codecov I realized the merging of the reports is done automatically, no need for the merge_coverage job.
  • Adds python 3.8 and 3.9 tests
  • Cirrus CI has no credits charge for open source projects, this includes windows, macOS and linux jobs.

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@vinferrer
Copy link
Collaborator Author

@smoia this is ready for approval

@smoia smoia assigned smoia and unassigned eurunuela Jan 19, 2021
@smoia
Copy link
Member

smoia commented Jan 19, 2021

Approved and merged!

@smoia
Copy link
Member

smoia commented Jan 19, 2021

Please open the same PR for phys2denoise though!
@62442katieb and @rmarkello , would you have anything against adopting CirrusCI for peakdet?

@vinferrer
Copy link
Collaborator Author

Okay but let me rest

@smoia smoia merged commit 3b19c51 into physiopy:master Jan 19, 2021
@62442katieb
Copy link
Contributor

Please open the same PR for phys2denoise though!
@62442katieb and @rmarkello , would you have anything against adopting CirrusCI for peakdet?

Nothing at all, go ahead!

@rmarkello
Copy link
Member

Agreed, that's totally fine 👍💯

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

13 similar comments
@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia smoia added the released This issue/pull request has been released. label Jan 21, 2021
@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

5 similar comments
@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

@smoia
Copy link
Member

smoia commented Jan 21, 2021

🚀 PR was released in 2.3.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circle CI Credits
6 participants