Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributions and remove auto all-contribution plugin #372

Merged
merged 9 commits into from
Dec 13, 2020

Conversation

smoia
Copy link
Member

@smoia smoia commented Dec 13, 2020

Closes #227 (we'll open a new issue to track contributions soon)

Long story short, the auto plugin to automatically use all-contributors is either not perfectly calibrated or actually something that doesn't work for us, given the way we approach reviews. So I'm updating contributions in view of ISMRM/OHBM abstracts submissions and removing the plugin from auto.

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Skip release This PR preserves the current version when merged, and doesn't appear in the changelog label Dec 13, 2020
@smoia smoia self-assigned this Dec 13, 2020
@smoia smoia merged commit f587559 into physiopy:master Dec 13, 2020
@smoia smoia deleted the contributors branch December 13, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip release This PR preserves the current version when merged, and doesn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check all-contributors is up to date
1 participant