-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows CI testing #366
Conversation
Wow, this was surprisingly easy, One integration test for windows already running in circle ci |
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 8 8
Lines 840 840
=======================================
Hits 795 795
Misses 45 45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the suggestions are added. This time your lowercase names are not escaping from me 😝
Co-authored-by: Eneko Uruñuela <[email protected]>
Co-authored-by: Eneko Uruñuela <[email protected]>
Co-authored-by: Eneko Uruñuela <[email protected]>
@eurunuela , you wanted to recheck this |
Closes #303
Proposed Changes
Change Type
bugfix
(+0.0.1)minor
(+0.1.0)major
(+1.0.0)refactoring
(no version update)test
(no version update)infrastructure
(no version update)documentation
(no version update)other
Checklist before review