Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows CI testing #366

Merged
merged 16 commits into from
Dec 9, 2020
Merged

Add windows CI testing #366

merged 16 commits into from
Dec 9, 2020

Conversation

vinferrer
Copy link
Collaborator

@vinferrer vinferrer commented Dec 4, 2020

Closes #303

Proposed Changes

  • Add Windows CI testing
  • one job for integration and another for unitest
  • delete azure pipelines when done

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@vinferrer
Copy link
Collaborator Author

Wow, this was surprisingly easy, One integration test for windows already running in circle ci

@vinferrer vinferrer requested a review from eurunuela December 4, 2020 10:23
@vinferrer vinferrer requested a review from smoia December 4, 2020 10:24
@vinferrer vinferrer marked this pull request as ready for review December 4, 2020 10:29
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #366 (1505175) into master (0e0ec5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files           8        8           
  Lines         840      840           
=======================================
  Hits          795      795           
  Misses         45       45           

@vinferrer vinferrer added Skip release This PR preserves the current version when merged, and doesn't appear in the changelog Testing This is for testing features, writing tests or producing testing code labels Dec 4, 2020
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the suggestions are added. This time your lowercase names are not escaping from me 😝

@vinferrer
Copy link
Collaborator Author

@eurunuela , you wanted to recheck this

@eurunuela eurunuela merged commit 42bbffd into physiopy:master Dec 9, 2020
@vinferrer vinferrer deleted the test_windows branch December 10, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip release This PR preserves the current version when merged, and doesn't appear in the changelog Testing This is for testing features, writing tests or producing testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests on Windows using CircleCI
2 participants