Add test to check that phys2bids output is BIDS compatible

[vinferrer]

Closes #355

This addition to the config file sets a test that runs bids_validator on the tutorial file

Proposed Changes

• add tests for bids_validator

Change Type

• bugfix (+0.0.1)
• minor (+0.1.0)
• major (+1.0.0)
• refactoring (no version update)
• test (no version update)
• infrastructure (no version update)
• documentation (no version update)
• other

Checklist before review

• I added everything I wanted to add to this PR.
• [Code or tests only] I wrote/updated the necessary docstrings.
• [Code or tests only] I ran and passed tests locally.
• [Documentation only] I built the docs locally.
• My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
• My code respects the adopted style, especially linting conventions.
• The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
• I added or indicated the right labels.

• I added information regarding the timeline of completion for this PR.

• Please, comment on my PR while it's a draft and give me feedback on the development!

[vinferrer]

Okay, I think this is working, l am gonna leave it as a draft until the PR mentioned in this issue: https://neurostars.org/t/quick-validation-failed-on-physiological-files/17611/6 gets approved and a new release is passed. However as you can see it is doing exactly what we want. Now that the bids-validator doesn't accept physiological only bids dataset it gives an error and breaks the test.

[vinferrer]

@eurunuela How do you use the makeenv_37 enviroment work in your others jobs? I tried to recreate the steps but since i couldn't i reisntall phys2bids in my bids_validate job

[eurunuela]

@eurunuela How do you use the makeenv_37 enviroment work in your others jobs? I tried to recreate the steps but since i couldn't i reisntall phys2bids in my bids_validate job

I think you're missing this:

- bids_validate
    requires:
      - makeenv_37

[eurunuela]

LGTM! Thank you @vinferrer . I set it as "request changes" until the test passes. Then I'll approve.

Edit: I forgot to mention that if you think this is ready for review, you should click on the button 😉

[vinferrer]

LGTM! Thank you @vinferrer . I set it as "request changes" until the test passes. Then I'll approve.

Edit: I forgot to mention that if you think this is ready for review, you should click on the button 😉

No, it's not ready, we have to wait for the bids-validator update that accepts only physiological datasets, then i will push an empty commit to see if the test passes or if there is something else to correct

[vinferrer]

I think bids-validator people are not gonna allow only physio datasets, So I decided to put a dummy file

[codecov]

Codecov Report

Merging #362 (8febea1) into master (fa5238c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files           8        8           
  Lines         840      840           
=======================================
  Hits          795      795           
  Misses         45       45           

Impacted Files	Coverage Δ
phys2bids/bids.py	98.05% <100.00%> (ø)

[smoia]

LGTM!

[eurunuela]

This is super useful. Thank you @vinferrer !

[smoia]

🚀 PR was released in 2.3.2 🚀