Add support for MATLAB files

[vinferrer]

Closes #25 and closes #292

Proposed Changes

• add load_mat function to io.py
• add test for this new function
• acknowledge @eurunuela work on this

Change Type

• bugfix (+0.0.1)
• minor (+0.1.0)
• major (+1.0.0)
• refactoring (no version update)
• test (no version update)
• infrastructure (no version update)
• documentation (no version update)
• other

Checklist before review

• I added everything I wanted to add to this PR.
• [Code or tests only] I wrote/updated the necessary docstrings.
• [Code or tests only] I ran and passed tests locally.
• [Documentation only] I built the docs locally.
• My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
• My code respects the adopted style, especially linting conventions.
• The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
• I added or indicated the right labels.

• I added information regarding the timeline of completion for this PR.

• Please, comment on my PR while it's a draft and give me feedback on the development!

[codecov]

Codecov Report

Merging #360 (5f4b837) into master (9e29b7a) will decrease coverage by 0.16%.
The diff coverage is 90.62%.

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   94.80%   94.63%   -0.17%     
==========================================
  Files           8        8              
  Lines         808      839      +31     
==========================================
+ Hits          766      794      +28     
- Misses         42       45       +3     

Impacted Files	Coverage Δ
phys2bids/phys2bids.py	88.06% <0.00%> (-1.53%)	⬇️
phys2bids/io.py	99.39% <100.00%> (+0.12%)	⬆️
phys2bids/utils.py	98.52% <100.00%> (ø)

[vinferrer]

Do we want an integration test for mat extension files?

[eurunuela]

I would say no. It should be enough if we unit test how the data is read and what it's transformed to. Once the mat files are read and transformed, they're "just another extension".

[smoia]

Minimal changes, but otherwise great job!

We might need to think about a smart way to run integration tests on different types (e.g. matlab, acq, ...) of the same file, but I wouldn't block this PR for that!

[smoia]

Could you move interfaces before tests and just change acq and mat in tests to "interfaces"?

[vinferrer]

You sure? I put this here because test were failing

[smoia]

Yes, if you add %(mat)s to the interfaces and move it before tests, it will work.

interfaces =
    %(acq)s
    %(mat)s
test =
    pytest >=5.3
    pytest-cov
    %(interfaces)s
    %(style)s

In fact, I will push a little patch to change the way we install phys2bids in CircleCI later, but for the moment, this would be better.

[smoia]

Ah, sorry, I forgot one point:
you should change line 11 of phys2bids.utils: from
SUPPORTED_FTYPES = ('acq', 'txt') # 'mat', ...
to
SUPPORTED_FTYPES = ('acq', 'txt', 'mat') # , ...

[eurunuela]

LGTM! Thank you @vinferrer ! We're finally adding support for MATLAB 💪🏻

[smoia]

LGTM!

[smoia]

🚀 PR was released in 2.3.0 🚀