Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more "change type" options #347

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Add more "change type" options #347

merged 1 commit into from
Nov 13, 2020

Conversation

smoia
Copy link
Member

@smoia smoia commented Nov 13, 2020

Closes #

Proposed Changes

  • Add more change type options in the PR template

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • internal (no version update)
  • documentation (no version update)

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #347 (297c379) into master (89e836b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files           9        9           
  Lines         840      840           
=======================================
  Hits          797      797           
  Misses         43       43           

@smoia smoia merged commit 0493248 into master Nov 13, 2020
@smoia
Copy link
Member Author

smoia commented Nov 13, 2020

Merging with supercow powers

@smoia smoia deleted the int/add_labels branch November 13, 2020 09:15
@smoia smoia self-assigned this Nov 13, 2020
@smoia
Copy link
Member Author

smoia commented Nov 29, 2020

🚀 PR was released in 2.3.0 🚀

@smoia smoia added the released This issue/pull request has been released. label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant