Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename function utils.writefile to utils.write_file to respect style conventions #343

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

ineschh
Copy link
Contributor

@ineschh ineschh commented Nov 11, 2020

Closes #332

Proposed Changes

  • Rename the function
  • Update tests
  • Update all uses of the function throughout the package

Didn't update the API page of docs since apparently there isn't one for utils

Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smoia
Copy link
Member

smoia commented Nov 11, 2020

@eurunuela wanna have a look?

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #343 (d928a7b) into master (106f8ad) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   94.81%   94.94%   +0.13%     
==========================================
  Files           9        9              
  Lines         848      871      +23     
==========================================
+ Hits          804      827      +23     
  Misses         44       44              
Impacted Files Coverage Δ
phys2bids/bids.py 98.05% <100.00%> (ø)
phys2bids/phys2bids.py 89.53% <100.00%> (ø)
phys2bids/utils.py 97.97% <100.00%> (+0.61%) ⬆️

@smoia smoia changed the title #332 utils.writefile to utils.write_file Rename function utils.writefile to utils.write_file to respect style Nov 11, 2020
@smoia smoia added the Refactoring Improve nonfunctional attributes label Nov 11, 2020
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eurunuela eurunuela merged commit 9dbfbcb into physiopy:master Nov 11, 2020
@eurunuela
Copy link
Collaborator

🔔

@smoia smoia self-assigned this Nov 12, 2020
@smoia smoia changed the title Rename function utils.writefile to utils.write_file to respect style Rename function utils.writefile to utils.write_file to respect style conventions Nov 13, 2020
@smoia
Copy link
Member

smoia commented Nov 29, 2020

🚀 PR was released in 2.3.0 🚀

@smoia smoia added the released This issue/pull request has been released. label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Improve nonfunctional attributes released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename utils.writefile() to utils.write_file()
3 participants