Remove utils.move_file() function as it is no longer used in the toolbox

[viacovella]

#Closes #336 and #closes #337

Proposed Changes

• Removes the in-house built function to move the files from the Utilities collection;
• Removes the test for in-house built function to move the files from the Unit test for Utilities collection.

[smoia]

LGTM!

@viacovella can you change the first line in the first PR message to "Closes #336 and closes #337"?

[smoia]

Oh, I spoke too soon 😅

The style test is failing because there was a line missing between two functions. Can you correct that please?

[eurunuela]

Thank you @viacovella ! I think this is a very simple refactoring PR and two reviews are not really necessary for this one. What do you think @smoia ?

[smoia]

Ok, we're close @viacovella, we're close.

[smoia]

@viacovella flake8 is not your friend today!

Check here to know what the problem is.

In this case, apparently there's a whitespace in the line you added.

Can I ask you what are you using to write your scripts? Sometimes adding some linter plugin helps dramatically in avoiding these little issues. I can help you set them up.

[eurunuela]

Can I ask you what are you using to write your scripts? Sometimes adding some linter plugin helps dramatically in avoiding these little issues. I can help you wet them up.

I'd also suggest that you tune your IDE settings to show you whitespace. It's incredibly useful for these kinds of errors.

[eurunuela]

The style check passed, so this should be ready.

Thank you @viacovella !

[codecov]

Codecov Report

Merging #342 (0d8cbb9) into master (106f8ad) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   94.81%   94.89%   +0.08%     
==========================================
  Files           9        9              
  Lines         848      843       -5     
==========================================
- Hits          804      800       -4     
+ Misses         44       43       -1     

Impacted Files	Coverage Δ
phys2bids/utils.py	98.59% <ø> (+1.22%)	⬆️

[smoia]

Ok, I think this is ready!

Since this is not only your first PR, but your first Brainhack PR, here's a gong for you!

🛎️

(Or the closest thing we can get with GH emojis)

[eurunuela]

This PR won't trigger auto right?

[smoia]

I have no idea since it's the first refactoring we merge. I don't think so though, no.

[smoia]

🚀 PR was released in 2.3.0 🚀