Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create folder code/conversion to store trigger and channel plots, yaml and heuristic files and the call.sh file #256

Merged
merged 17 commits into from
Jun 18, 2020
Merged

Create folder code/conversion to store trigger and channel plots, yaml and heuristic files and the call.sh file #256

merged 17 commits into from
Jun 18, 2020

Conversation

vinferrer
Copy link
Collaborator

@vinferrer vinferrer commented Jun 18, 2020 •
edited by eurunuela
Loading

Closes #256

Proposed Changes

  • Create code/coversion folder
  • generating log, trigger_plot, channel_plot, heuristic file and yam file to code/coversion folder
  • create new file call.sh that contains the original call to phys2bids

@vinferrer vinferrer added BrainHack This issue is suggested for BrainHack participants! Refactoring Improve nonfunctional attributes labels Jun 18, 2020
@vinferrer vinferrer changed the title code/coversion folder Create folder code/coversion and add contents Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #256 into master will decrease coverage by 0.17%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   93.66%   93.48%   -0.18%     
==========================================
  Files           8        9       +1     
  Lines         742      783      +41     
==========================================
+ Hits          695      732      +37     
- Misses         47       51       +4
Impacted Files Coverage Δ
phys2bids/phys2bids.py 90.97% <77.77%> (+1.14%) ⬆️
phys2bids/due.py 84.61% <0.00%> (ø)

@eurunuela eurunuela added Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) and removed BrainHack This issue is suggested for BrainHack participants! Refactoring Improve nonfunctional attributes labels Jun 18, 2020
@eurunuela
Copy link
Collaborator

If the tests pass, this should be ready @vinferrer @smoia

@vinferrer
Copy link
Collaborator Author

It says that there is coverage dropout

@eurunuela
Copy link
Collaborator

That's weird. The report inside codevoc shows an increase in coverage...

@eurunuela
Copy link
Collaborator

I can add a test to check that the file is generated in the integration tests.

@vinferrer
Copy link
Collaborator Author

please do

@eurunuela
Copy link
Collaborator

Done!

@vinferrer vinferrer marked this pull request as ready for review June 18, 2020 13:56
eurunuela
eurunuela approved these changes Jun 18, 2020
View reviewed changes
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @vinferrer !

@eurunuela eurunuela requested a review from smoia June 18, 2020 14:10
@vinferrer
Copy link
Collaborator Author

@smoia had death by brainhack

@eurunuela eurunuela mentioned this pull request Jun 18, 2020
Closed
3 tasks
smoia
smoia approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eurunuela eurunuela changed the title Create folder code/coversion and add contents Create folder code/conversion to store trigger and channel plots, yaml and heuristic files and the call.sh file Jun 18, 2020
@eurunuela eurunuela merged commit 8d42c28 into physiopy:master Jun 18, 2020
@vinferrer vinferrer deleted the file_restruct branch June 18, 2020 16:54
@smoia smoia added the released This issue/pull request has been released. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela approved these changes

@smoia smoia smoia approved these changes

Assignees

@eurunuela eurunuela

Labels
Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinferrer @eurunuela @smoia