Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexporting types used from the term crate #78

Merged
merged 2 commits into from
Apr 18, 2018

Conversation

hoodie
Copy link
Contributor

@hoodie hoodie commented Apr 15, 2018

This exports term types so that you don't have to use external types in your api

@hoodie
Copy link
Contributor Author

hoodie commented Apr 17, 2018

@phsym would you agree that it's time to stop supporting 1.13 and 1.14?

@phsym
Copy link
Owner

phsym commented Apr 17, 2018

@hoodie I do. All of this will be released in 0.7.0 so we can break a few things.

@phsym
Copy link
Owner

phsym commented Apr 17, 2018

I think you can use the following syntax (or similar)

pub (crate) use ....;

in order to make an export publicly available but only from the crate itself

@phsym phsym added this to the v0.7.0 milestone Apr 17, 2018
@hoodie
Copy link
Contributor Author

hoodie commented Apr 17, 2018

I was gonna do that, but that does not build on 1.13 and 1.14 :D

@hoodie hoodie force-pushed the feature/export-term-types branch from 20b4b9b to deb86bd Compare April 17, 2018 17:55
@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #78 into master will increase coverage by 0.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   83.31%   84.15%   +0.83%     
==========================================
  Files           5        5              
  Lines        1157     1136      -21     
==========================================
- Hits          964      956       -8     
+ Misses        193      180      -13
Impacted Files Coverage Δ
src/cell.rs 82.56% <ø> (ø) ⬆️
src/lib.rs 85.43% <ø> (+0.41%) ⬆️
src/row.rs 89.57% <ø> (-0.07%) ⬇️
src/format.rs 72.72% <0%> (+2.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d9492...f718728. Read the comment docs.

@hoodie
Copy link
Contributor Author

hoodie commented Apr 17, 2018

oops, actually we would have to retire every version up to 1.18.0
I guess that's still reasonable though

Copy link
Owner

@phsym phsym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update the rust compatibility note in the README

@phsym
Copy link
Owner

phsym commented Apr 18, 2018

Dropping supoprt for rust releases prior to 1.18.0 is ok. The CI is much faster now 😄

@phsym phsym merged commit 1a6c738 into phsym:master Apr 18, 2018
phsym added a commit that referenced this pull request Apr 18, 2018
@phsym
Copy link
Owner

phsym commented Apr 18, 2018

Just figured out a few changes missing after I merged. I updated the master directly.

Thanks for your changes @hoodie

@hoodie
Copy link
Contributor Author

hoodie commented May 4, 2018

gentle reminder to release 0.7.0 already 😀
PLZ

@phsym
Copy link
Owner

phsym commented May 4, 2018

Ooops. Now it's release. Sorry I'm quite busy this time :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants