-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reexporting types used from the term crate #78
Conversation
@phsym would you agree that it's time to stop supporting 1.13 and 1.14? |
@hoodie I do. All of this will be released in |
I think you can use the following syntax (or similar) pub (crate) use ....; in order to make an export publicly available but only from the crate itself |
I was gonna do that, but that does not build on 1.13 and 1.14 :D |
20b4b9b
to
deb86bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 83.31% 84.15% +0.83%
==========================================
Files 5 5
Lines 1157 1136 -21
==========================================
- Hits 964 956 -8
+ Misses 193 180 -13
Continue to review full report at Codecov.
|
oops, actually we would have to retire every version up to 1.18.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update the rust compatibility note in the README
Dropping supoprt for rust releases prior to 1.18.0 is ok. The CI is much faster now 😄 |
Just figured out a few changes missing after I merged. I updated the master directly. Thanks for your changes @hoodie |
gentle reminder to release 0.7.0 already 😀 |
Ooops. Now it's release. Sorry I'm quite busy this time :/ |
This exports term types so that you don't have to use external types in your api