Regression test for #1657

phpstan · Nov 28, 2020 · 83d15e3 · 83d15e3
1 parent 83c1e0b
commit 83d15e3
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -10424,6 +10424,11 @@ public function dataBug2997(): array
 		return $this->gatherAssertTypes(__DIR__ . '/data/bug-2997.php');
 	}
 
+	public function dataBug1657(): array
+	{
+		return $this->gatherAssertTypes(__DIR__ . '/data/bug-1657.php');
+	}
+
 	/**
 	 * @param string $file
 	 * @return array<string, mixed[]>
@@ -10609,6 +10614,7 @@ private function gatherAssertTypes(string $file): array
 	 * @dataProvider dataBug4099
 	 * @dataProvider dataBug3760
 	 * @dataProvider dataBug2997
+	 * @dataProvider dataBug1657
 	 * @param string $assertType
 	 * @param string $file
 	 * @param mixed ...$args

diff --git a/tests/PHPStan/Analyser/data/bug-1657.php b/tests/PHPStan/Analyser/data/bug-1657.php
@@ -0,0 +1,23 @@
+<?php
+
+namespace Bug1657;
+
+use function PHPStan\Analyser\assertType;
+
+/**
+ * @param string|int $value
+ */
+function foo($value)
+{
+	assertType('int|string', $value);
+	try {
+		assert(is_string($value));
+		assertType('string', $value);
+
+	} catch (\Throwable $e) {
+		$value = 'A';
+		assertType('\'A\'', $value);
+	}
+
+	assertType('string', $value);
+};