Unspecific assert methods not detected when called on Assert class directly

[Majkl578]

The following is detected inside a test and assertNull is suggested:

$this->assertSame(null, $foo);
self::assertSame(null, $foo);

However the following is not:

Assert::assertSame(null, $foo);

[ondrejmirtes]

This line should become a union of TestCase and Assert and it will start working... https://github.com/phpstan/phpstan-phpunit/blob/master/src/Rules/PHPUnit/AssertRuleHelper.php#L14

[Majkl578]

Maybe it could be only Assert since TestCase extends Assert? 😅

[ondrejmirtes]

Yes

On Fri, 10 May 2019 at 13:16, Michael Moravec ***@***.***> wrote: Maybe it could be only Assert since TestCase extends Assert? 😅 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZTOE3GBDZZOO5N4OOI73PUVKSLANCNFSM4HMBHKDA> .

-- Ondřej Mirtes

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.