Fixed bug #62202 (ReflectionParameter::getDefaultValue() leaks with constand #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why my comment disappeared? what did you do? |
|
it lost when I force-updated the PR, |
|
thanks for spotting this issue, however I got another fix, committed here: 1f5327a thanks |
|
Comment on behalf of laruence at php.net: another fix has beend committed, closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found this leaks when testing reflection related functions.
This happend because when compiling constant zval.type will add IS_CONSTANT_UNQUALIFIED.
Thank:)