Fix pcre.jit on Apple Silicon

[kelunik]

This backports zherczeg/sljit#105. Relates to bug 80435, however, it doesn't solve the bus error on PHP 8.0, but PHP 8.1 builds fine now.

[devnexen]

Might be the appropriate approach for 8.1, master had been updated to pcre 10.40 cc @cmb69

[kelunik]

I guess PHP 8.0 also needs zherczeg/sljit#90, but it doesn't apply cleanly to the currently bundled version. Should we upgrade pcre2 there as well or just be happy with it working with jit on PHP 8.1+?

[cmb69]

Thank you! This patch looks good for PHP-8.1.

I wouldn't change too much regarding PHP-8.0, since active support for that version ends in a few months. So if we're fine with leaving PHP-8.0 as is, good. Otherwise, it's up for the RMs to decide what to do.

[bwoebi]

@cmb69 I think the point of active support is that such issues are fixed. Unless this is a change with high risk.

[cmb69]

Unless this is a change with high risk.

That's my point. Updating the bundled libpcre from a patched 10.35 to 10.39 or 10.40 might cause all kinds of subtle issues.

@sgolemon, @carusogabriel, thoughts about that?

[devnexen]

@cmb69 I think the point of active support is that such issues are fixed. Unless this is a change with high risk.

The other alternative would be for the related os/package manager to patch the source (it s very common homebrew, freebsd pkg ... etc do that all the time)

[bwoebi]

@cmb69 Oh, you're talking about upgrading the bundled version, I thought it would be about applying some patch. Sorry for the confusion then.

[kelunik]

@bwoebi @cmb69 We can also apply the patch in zherczeg/sljit#90 to the bundled version in 8.0, it just doesn't apply cleanly and I have no idea whether there are other patches missing.

[cmb69]

We can also apply the patch in zherczeg/sljit#90 to the bundled version in 8.0, it just doesn't apply cleanly and I have no idea whether there are other patches missing.

Me neither. And that is exactly the point; we might break other stuff, and that very late in the 8.0 release cycle.

[kelunik]

@cmb69 So let's merge this into 8.1 and worry about 8.0 if someone wants to build it?

[cmb69]

So let's merge this into 8.1 and worry about 8.0 if someone wants to build it?

Yes. Thank you!