Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform variable syntax #686

Closed
wants to merge 33 commits into from
Closed

Uniform variable syntax #686

wants to merge 33 commits into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Jun 6, 2014

@Tyrael
Copy link
Contributor

Tyrael commented Jun 6, 2014

awesome!

@JanTvrdik
Copy link

👍

1 similar comment
@hrach
Copy link

hrach commented Jun 8, 2014

👍

@smalyshev
Copy link
Contributor

I like it. 👍

@brandonwamboldt
Copy link

👍 Would love to have these changes

@rquadling
Copy link
Contributor

Brilliant work. Very very impressed. Is there a way to determine how much
(if any) actual uses of the incompatible usages there are in common
apps/libraries? I suppose that is EXACTLY why unit testing exists, but as
well all know, not everything is.

But that aside, the RFC is very clear and understandable.

On 9 June 2014 16:08, Brandon Wamboldt [email protected] wrote:

[image: 👍] Would love to have these changes


Reply to this email directly or view it on GitHub
#686 (comment).

Richard Quadling
Twitter : @rquadling
EE : http://e-e.com/M_248814.html
Zend : http://bit.ly/9O8vFY

@Tyrael
Copy link
Contributor

Tyrael commented Jun 9, 2014

@rquadling the RFC mentions testing two mainstream php framework (ZF and Symfony, would be nice showing the exact version numbers tested) but ofc. running more userland unittests agains phpng and this particular PR would be helpful for indentifying the severity of the BC breaks.

@echochamber
Copy link

👍

3 similar comments
@hfern
Copy link

hfern commented Jun 10, 2014

👍

@maroon775
Copy link

👍

@KonstantinKuklin
Copy link

👍

@igor822
Copy link

igor822 commented Jun 22, 2014

Yess

@Hywan
Copy link
Contributor

Hywan commented Jul 7, 2014

👍

@php-pulls
Copy link

Comment on behalf of nikic at php.net:

Closing, as this has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.