-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Travis CI #68
Conversation
This is awesome, thanks! |
If this gets merged in and you guys are interested in pull-request testing then shoot us a note at [email protected]. This feature is currently being rolled out manually but we'd love to turn it on for php. |
With 355cf75 the tests are now running against MySQL, PgSQL, and SQLite, and covers 53 extensions, running 99.2% of the full test suite. I'm thinking seeing as this is a PHP 5.4 box, that we can use |
Cool, Travis is awesome. |
FYI looking into it. General idea is great, have to read about travis, etc first. |
@@ -332,6 +332,7 @@ function write_information($show_html) | |||
define('PHP_QA_EMAIL', '[email protected]'); | |||
define('QA_SUBMISSION_PAGE', 'http://qa.php.net/buildtest-process.php'); | |||
define('QA_REPORTS_PAGE', 'http://qa.php.net/reports'); | |||
define('TRAVIS_CI' , !!getenv('TRAVIS_PHP_VERSION')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like idomatic JavaScript code. If you want to convert it to a boolean use
define('TRAVIS_CI', (boolean) getenv('TRAVIS_PHP_VERSION'));
I like the idea. If there are no objections from internals I will go ahead and merge that once you squelched the little issues. |
for the REPORT_EXIT_STATUS problem see https://bugs.php.net/bug.php?id=60285 |
I know someone who is working on firebird support for travis but I have no idea how long that will take him. |
@Tyrael would be great to have that fixed :) |
By Davey Shafik via Davey Shafik * pull-request/68: Fix boolean casting and whitespace (@dsp / #68) Add curl extension config, uses cli-server to test Source all extension scripts for ENV vars Add extension configs, compile more extensions Reformat, setup MySQL DB, call run-tests directly Add support for Travis CI
Merged. Let's see how it works out |
looks like tests on masters are currently failing, ci.qa.php.net shows 13 failing while travis has 52 failing. |
This is more of a proof of concept; it configures, builds and tests PHP with each commit.
What doesn't work:
1
when there are failed tests despite settingREPORT_EXIT_STATUS=1
I'd like to:
apt-get
I'm just throwing this out here right now to gauge interest, and to see if anyone else wants to contribute :)
You can see this in action here, or just look at: