Add ldap_escape() #458
Merged
Add ldap_escape() #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather see static tables than generating the escape maps dynamically. |
|
@m6w6 The reason behind this particular design choice is to enable the ignore list to exist. This patch is a variation on something I've used in userland for a while, and I can tell you with absolute certainty that the ignore list has real-world value, it's not just a "seems like people might need this" feature. In order to implement this element it needs to be a dynamically generated map. I can remove this portion of the functionality so it's just |
|
Oh well, I should have had a closer look. I didn't notice yoiu were changing the map after generating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch defines a new function and two new constants in ext/ldap:
ldap_escape()LDAP_ESCAPE_DNLDAP_ESCAPE_FILTEREscaping is done according to the relevant RFCs:
http://tools.ietf.org/html/rfc1960 (FIlter)
http://tools.ietf.org/html/rfc2253 (DN)
The function also allows the user to specify a list of characters that will not be escaped.
Resolves https://bugs.php.net/bug.php?id=47607