Dedicated syntax for variadic parameters

[nikic]

Implementation for https://wiki.php.net/rfc/variadics RFC.

[clemherreman]

RFC can be found here: https://wiki.php.net/rfc/variadics

I genuinely find this a good thing, especially for the type hinting. Being able to explicitely indicate that a function is variadic via its signature is way better than looking at documentation or directly by looking at its code.

So a big +1 :)

[failpunk]

Is the syntax space sensitive? Same examples have a space after the ellipsis and some do not.

public function query($query, ...$params) 

public function prepare($query, &... $params)

[nikic]

@failpunk No, whitespace doesn't matter (as with all of PHP).

[smalyshev]

Why this change I wonder?

[nikic]

I refactored some of the magic method implementation checks (and changed the error message doing that), but that turned out to be unnecessary in the end. I now removed the changes to avoid cluttering the diff.

[olekukonko]

Its good to see PHP is about to support variadic functions just like in go but slightly different. I would like want to know if this code below return expected output :

function  A($x,$y,$z) {

    printf("%d,%d,%d",$x,$y,$z);
}

function B(...$vars) {
    A(...$vars);
}

function C($no, ...$vars) {
    foreach ($vars as &$var) {
        $var = $var * $no ;
    }
    A(...$vars);
}

B(1,2,3); // Expect  1,2,3  
C(2,1,2,3); // Expect  2,4,8  

Would this work this way or how do you achieve this with current implementation. Secondly can arrays be simple used. eg

A(...[1,10,100]); // Expect 1,10,100

//OR

$array = array_reverse(range(1,100))
A(...$array) // Expect 100,99,98 

I really this not see clarification of this usage case in the RFC. Can you please clarify ?

[smalyshev]

@olekukonko you can always use call_user_func_array() for that. For the last example, I don't even see why would you bother to write A(...[1,10]) if you can just write A(1,10).

[olekukonko]

@smalyshev that was just an example .... there is so many use cases for A(...$array)

[smalyshev]

@olekukonko All of which, as far as I can see, are covered by call_user_func_array().

[slavcodev]

May be use function fn(&$var, ...&$params) instead of function fn(&$var, &...$params)
It is more consistent.

[php-pulls]

Comment on behalf of nikic at php.net:

Has been merged.

[kaplanlior]

For future reference, commit SHA1 is 0d7a638