typofixes - code related #395
Conversation
|
Whereby such fixes are nice, do you actually run the tests after them? Last time such fixes came in I could count at least 3 testfails. That's of course not bad, but costs time to figure out. |
|
Not yet... I spent a half an hour to guess how I should, but I failed. Could you please send me some instructions/url? Thanks. |
| @@ -61,7 +61,7 @@ | |||
| typedef struct _XML_Parser { | |||
| int use_namespace; | |||
|
|
|||
| xmlChar *_ns_seperator; | |||
| xmlChar *_ns_separator; | |||
There was a problem hiding this comment.
I'm afraid since this is an externally accessible structure, we can not just change the name. At least we'd have to have aliased #define for it.
There was a problem hiding this comment.
What do you think about the solution in the next commit? (I couldn't test it...)
There was a problem hiding this comment.
Yes, this probably would work
|
Comment on behalf of stas at php.net: merged |
typo fixes