Fix saving of -1 index from keys column in array_column function #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment on behalf of yohgaki at php.net: Fix was committed. Thank you. |
|
@yohgaki - I didn't see the merge in the git repo, could you verify it's merged? |
|
That's correct. I have requested the closing of this ticket because the fix has been already implemented when the function implementation has been rewritten (think that it was commit from Sara...) ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of array_column function does not allow saving of -1 index as a key. See http://3v4l.org/fT1th (the next index is used in place of -1). This patch fixes the problem. I also added new test array_column_minus_one_index.phpt . All other tests for arrray_column passed as well.