Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fix bug #61541, Segfault when using ob_* in output_callback #25

Closed
wants to merge 1 commit into from

Conversation

reeze
Copy link
Contributor

@reeze reeze commented Mar 28, 2012

@see tests/output/ob_011.phpt there is a XFAIL

In PHP5.4 using ob_* functions in output_callback will issue Fatal error, but in 5.3 only calling ob_start() function will raise Fatal error ,but calling ob_clean/flush* functions will cause Segfault because of the endless recurse function call.

maybe the patch isn't perfect, please don't hesitate to let me know.

@yohgaki
Copy link
Contributor

yohgaki commented Mar 28, 2012

Thanks for the patch. I'll merge it after run-tests.php finished.

@php-pulls
Copy link

Comment on behalf of yohgaki at php.net:

Applied. Thank you.

@php-pulls php-pulls closed this Mar 29, 2012
@reeze
Copy link
Contributor Author

reeze commented Apr 3, 2012

@yohgaki I didn't add the bug fix for #61541 to 5.3 branch's NEWS file. could you do it for me? another pull request seems noise. thanks

@php-pulls
Copy link

On Tue, Apr 3, 2012 at 11:26 AM, reeze
[email protected]
wrote:

@yohgaki  I didn't add the bug fix for #61541 to 5.3 branch's NEWS file. could you do it for me? another pull request seems noise. thanks

the same bug exists in 5.3 too? as I remebered, 5.4 change the ouput
handler. it's different with 5.3.

thanks


Reply to this email directly or view it on GitHub:
#25 (comment)

Git Pull Requests Mailing List (https://github.com/php)
To unsubscribe, visit: http://www.php.net/unsub.php

Laruence  Xinchen Hui
http://www.laruence.com/

@reeze
Copy link
Contributor Author

reeze commented Apr 3, 2012

@php-pulls
Hi,
This bug exists only in 5.3 and this patch have applied to 5.3 abd2b2e :)

thanks.

@php-pulls
Copy link

On Tue, Apr 3, 2012 at 12:08 PM, reeze
[email protected]
wrote:

@php-pulls
 Hi,
  This bug exists only in 5.3   and this patch have applied to 5.3 abd2b2e :)

Hi:
oh , I see, I will do it for you.

thanks

thanks.


Reply to this email directly or view it on GitHub:
#25 (comment)

Git Pull Requests Mailing List (https://github.com/php)
To unsubscribe, visit: http://www.php.net/unsub.php

Laruence  Xinchen Hui
http://www.laruence.com/

@reeze
Copy link
Contributor Author

reeze commented Apr 3, 2012

Thanks Xinchen @laruence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants