support BITMAPV5HEADER in getimagesize() #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. Please add a Testcase for the addition. |
|
@AsamK you should also fix ext\standard\tests\image\image_type_to_mime_type.phpt as it picks up your new image file. Then it should be fine i'd say. |
|
@AsamK could you squash your commits, I’ll merge than. |
https://en.wikipedia.org/wiki/BMP_file_format#DIB_header_.28bitmap_information_header.29 added test image: ext/standard/tests/image/test1bpix.bmp and adapted tests: ext/standard/tests/image/getimagesize.phpt ext/standard/tests/image/image_type_to_mime_type
|
I squashed them. |
|
Looks good! I’ll try to merge them now. |
|
Comment on behalf of lstrojny at php.net: Merged into 5.4, 5.5 and master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the php function getimagesize() doesn't support Bitmaps with ICC color profiles (BITMAPV5HEADER).
The size information is at the same position as Bitmaps with a BITMAPV4HEADER, so just adding a check for the different header size should be enough
https://en.wikipedia.org/wiki/BMP_file_format#DIB_header_.28bitmap_information_header.29