Fixed bug #60285 (setting REPORT_EXIT_STATUS for make test won't work) #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment on behalf of laruence at php.net: this fix changed the behavior, that is the tmp-php.ini will not be clean if the test make failed, so I prefer the patch attached at the bug entry. thanks |
|
There is a reason: when tests failed, run-test.php will save test script like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.php.net/bug.php?id=60285
This is related to PR #232
after the patch:
REPORT_EXIT_STATUS=1 make testwill works as expected`this makes ci like travis easier
BTW @lstrojny #232 was merged to master only, I thought both #232 and this PR could apply
to all branches, or at least 5.5, what do you think?