Fixed bug #63428 (The behavior of execute() changed) #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Zend/tests/bug35437.phpt failed when zend_execute wasn't function execute, such as dtrace or xdebug enabled.
|
we prefer bugs.php.net, for such a minor fix, it's better if you don't open two threads... both here and bugs.php.net thanks |
|
Comment on behalf of laruence at php.net: bug fix in another way, since your fix will make all execute check twice EG(exception), anyway, thanks for reporting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the patch: f627be5
Test Zend/tests/bug35437.phpt failed when zend_execute
wasn't function execute, such as dtrace or xdebug enabled.
execute() will call zend_vm_stack_alloc even EG(exception) is not null (that was changed),
which will case segfault when testing bug35437.phpt