Fix phpcredits() BC after remove Logo GUIDs #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was affected: ext/standard/tests/general_functions/phpcredits2.phpt see https://github.com/php/php-src/pull/132/files#diff-3 This makes constant PHP_CREDITS_FULLPAGE didn't functional anymore.
|
Ah, my bad, my bad. Have you tested and made sure it embeds the credits properly in phpinfo()? |
|
Yes, it did embed correctly. and the test passed :) I was trying to contact you on irc but I can't login seems been banned because of share ip :( |
|
Have incorporated into this PR: #156 |
|
cool then this one could be closed Reeze 在 2012年8月10日星期五，2:10，Andrew Faulds 写道：
|
|
Comment on behalf of laruence at php.net: included in PR 156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was affected: ext/standard/tests/general_functions/phpcredits2.phpt
https://github.com/php/php-src/pull/132/files#diff-3
This makes constant PHP_CREDITS_FULLPAGE didn't functional anymore.
see: http://php.net/phpcredits
Hi, @TazeTSchnitzel you might want to take a look at this :)