Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-14926: yield /*comment*/ from is no longer a parse error #15276

Closed
wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Aug 7, 2024

[ci skip]


@jrfnl, could you please check the wording?

@cmb69
Copy link
Member Author

cmb69 commented Aug 7, 2024

If this PR will be merged, I will update the PHP manual (most notably the migration guide for PHP 8.3).

Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry has been added to the "Backward Incompatible Changes" section for "Core".

I wonder if it should be in "New features" for "Core" (as for end-users this is a new feature) instead, with a secondary entry in "Backward Incompatible Changes" specifically for the "Tokenizer" extension ?

@jrfnl
Copy link
Contributor

jrfnl commented Aug 8, 2024

@cmb69 Thanks for opening this PR !

@cmb69
Copy link
Member Author

cmb69 commented Aug 8, 2024

I wonder if it should be in "New features" for "Core" (as for end-users this is a new feature) instead, with a secondary entry in "Backward Incompatible Changes" specifically for the "Tokenizer" extension ?

It might be better to not advertize it. ;)

@jrfnl
Copy link
Contributor

jrfnl commented Aug 8, 2024

I wonder if it should be in "New features" for "Core" (as for end-users this is a new feature) instead, with a secondary entry in "Backward Incompatible Changes" specifically for the "Tokenizer" extension ?

It might be better to not advertize it. ;)

Fair point ;-)

@cmb69 cmb69 closed this in 7bb5a2e Aug 12, 2024
@cmb69 cmb69 deleted the cmb/gh14926 branch August 12, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.3: "yield /*comment*/ from" is no longer a parse error ?
3 participants