Tell Composer that this plugin modifies downloads #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedbow
approved these changes
Jul 9, 2024
|
The CI workflow proves that the plugin and its dependencies are installed first, then immediately activated, during the Is that good enough? I'm pretty sure manual testing at the console would produce the same result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://getcomposer.org/doc/articles/plugins.md#plugin-modifies-downloads.
I think we need this attribute for this plugin, even though we don't technically modify the download URLs -- but we do verify them, and therefore the behavior mentioned in the documentation (this plugin needs to be installed first) makes sense for us.