Skip to content

Commit

Permalink
GH Actions: fix failing tests on PHP 5.3-5.5
Browse files Browse the repository at this point in the history
I still can't fathom why the tests were previously passing and are failing now. I know they were running fine before as I checked the logs on multiple occasions.

I've now [unearthed the documentation from Nette Tester 1.x](https://web.archive.org/web/20170602082733/https://tester.nette.org/#toc-how-the-tester-runs) which what's used to run the tests on PHP 5.3-5.5.
The docs state:
> The Tester runs PHP processes with `-n` option, so without `php.ini`. More details in the [Own php.ini chapter](https://web.archive.org/web/20170602082733/https://tester.nette.org/#toc-own-php-ini).

... which in a way is similar to the problem we previously ran into for Nette Tester 2.x, which is why the `-C` (= Use system-wide `php.ini`) option is used there. Also see #55

As the tests were running and passing on Nette 1.x/PHP 5.3 - 5.5 previously, we never dug in deeper for the peculiarities of Nette 1.x.

So to fix the test runs against PHP 5.3 - 5.5, which are using Nette Tester 1.x, I'm proposing to add a `php.ini` file to the `tests` directory specifically for use with PHP 5.3 - 5.5.

This should get the tests passing again.

I'm adding villfa as co-author to this PR as I ended up with this solution inspired by [a PR they pulled to my fork of this repo](jrfnl/PHP-Parallel-Lint#1).

Co-authored-by: Fabien Villepinte <[email protected]>
  • Loading branch information
2 people authored and grogy committed Dec 1, 2021
1 parent 6ccb75f commit ba57322
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
],
"scripts": {
"test": "@php vendor/bin/tester -C -p php tests",
"testphp5": "@php vendor/bin/tester -p php tests"
"testphp5": "@php vendor/bin/tester -c tests/php5.3-5.5.ini -p php tests"
},
"scripts-descriptions": {
"test": "Run all tests!"
Expand Down
10 changes: 10 additions & 0 deletions tests/php5.3-5.5.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
[PHP]

extension=json.so
extension=tokenizer.so

memory_limit=512M

error_reporting=-1
display_errors=On
display_startup_errors = On

0 comments on commit ba57322

Please sign in to comment.