Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 8.1.0beta2 #54

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Fix for 8.1.0beta2 #54

merged 3 commits into from
Aug 4, 2021

Conversation

remicollet
Copy link
Contributor

Deprecated: Return type of SimpleKafkaClient\Metadata\Collection::current() should either be compatible with Iterator::current(): mixed, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
Deprecated: Return type of SimpleKafkaClient\Metadata\Collection::next() should either be compatible with Iterator::next(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

Sadly, this make usage of PHP 8.1 mandatory to generate arginfo... :(
(still usable with older version, thanks to compact macro added)

@remicollet
Copy link
Contributor Author

1st commit is only cleanup of local git snapshot
3rd commit is only to completeness of the archive, these files are really "sources", and part of the project

@nick-zh
Copy link
Member

nick-zh commented Aug 4, 2021

@remicollet wow, many thanks for the fix and the cleanup. I highly appreciate it 🙇

@nick-zh nick-zh merged commit b27868f into php-kafka:main Aug 4, 2021
@remicollet remicollet deleted the issue-php81b2 branch August 4, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants