Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling requests with nested files #227

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

mfb
Copy link
Contributor

@mfb mfb commented Apr 26, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #226
Documentation
License MIT

What's in this PR?

Borrows logic from guzzlehttp/psr7's ServerRequest class to fix processing of requests with nested files.

Why?

Example Usage

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • Update CHANGELOG.md

@nicolas-grekas nicolas-grekas changed the title Fixes #226 TypeError thrown by requests with nested files Fix handling requests with nested files Apr 26, 2023
Copy link
Collaborator

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mfb

@nicolas-grekas nicolas-grekas merged commit d5b4f0e into php-http:1.x Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Psr17Factory::buildServerRequestFromGlobals() throws TypeError when encountering nested array of file uploads
2 participants