Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate PSR - 4 to simplified Chinese #391

Merged
merged 1 commit into from
Dec 14, 2014
Merged

Translate PSR - 4 to simplified Chinese #391

merged 1 commit into from
Dec 14, 2014

Conversation

linkdesu
Copy link
Contributor

Hi , I translate PSR - 4 to simplified Chinese , hope it is helpful for others .

@dragoonis
Copy link
Member

@xieaolin thanks for providing this - we usually have a second member of the group verify the translations - since I don't believe anyone currently knows simplified chinese then I'm happy to approve this until someone raises any issues with it.

dragoonis added a commit that referenced this pull request Dec 14, 2014
Translate PSR - 4 to simplified Chinese
@dragoonis dragoonis merged commit bfc905e into php-fig:master Dec 14, 2014
@bobthecow
Copy link
Contributor

@dragoonis There were issues with it. Still are, in fact. Please revert this merge.

There were already three pending translations for (simplified) Chinese (#105, #358 and #364). There's plenty of discussion on all of those, and plenty of people there to give feedback on this one.

At the very least, #105 or #364 is more correct because it's using a real language code: Chinese is zh not cn. Technically Simplified Chinese is zh_CN.

@bobthecow
Copy link
Contributor

Oh sweet. #392 is a simplified Chinese translation too. Looks like @philsturgeon merged another PR with no 👍 after you merged this one. That merge should be reverted as well.

We need a Voltron pull request from all the people who wrote simplified Chinese translations. With their powers combined, it should be one awesome translation :)

What do you say, @hfcorriez @keryao @bronze1man @thbourlove @mylxsw @PizzaLiu @tangrucheng @xieaolin @gDD? Can we get some sort of consensus out of these 5 pull requests?

At the very least, can we put it in zn_CH?

@philsturgeon
Copy link
Contributor

@bobthecow let me know which PR to revert.

@bobthecow
Copy link
Contributor

@philsturgeon #391 and #392 should be reverted.

@philsturgeon
Copy link
Contributor

@bobthecow Done! Let me know when and where to click that shiny green button.

@philsturgeon
Copy link
Contributor

But hurry up because im outta this group in like 4 days.

@bobthecow
Copy link
Contributor

Thanks :)

@PizzaLiu
Copy link
Contributor

So,what to do next? Any thing I can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants