-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate PSR - 4 to simplified Chinese #391
Conversation
@xieaolin thanks for providing this - we usually have a second member of the group verify the translations - since I don't believe anyone currently knows simplified chinese then I'm happy to approve this until someone raises any issues with it. |
Translate PSR - 4 to simplified Chinese
@dragoonis There were issues with it. Still are, in fact. Please revert this merge. There were already three pending translations for (simplified) Chinese (#105, #358 and #364). There's plenty of discussion on all of those, and plenty of people there to give feedback on this one. At the very least, #105 or #364 is more correct because it's using a real language code: Chinese is |
Oh sweet. #392 is a simplified Chinese translation too. Looks like @philsturgeon merged another PR with no 👍 after you merged this one. That merge should be reverted as well. We need a Voltron pull request from all the people who wrote simplified Chinese translations. With their powers combined, it should be one awesome translation :) What do you say, @hfcorriez @keryao @bronze1man @thbourlove @mylxsw @PizzaLiu @tangrucheng @xieaolin @gDD? Can we get some sort of consensus out of these 5 pull requests? At the very least, can we put it in |
@bobthecow let me know which PR to revert. |
@philsturgeon #391 and #392 should be reverted. |
@bobthecow Done! Let me know when and where to click that shiny green button. |
But hurry up because im outta this group in like 4 days. |
Thanks :) |
So,what to do next? Any thing I can help? |
Hi , I translate PSR - 4 to simplified Chinese , hope it is helpful for others .