Modify meta doc #1230
Merged
Modify meta doc #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make some of the decisions taken more clear to people using the interface
The UTCClock is not really needed for a minimum implementation
This method is not really needed on a FrozenClock. And especially as a FrozenClock should be, well, frozen, there should be no way of modifying that information
Scheduler tasks are not part of retrieving the time and should be either handled by the implementation or by a different PSR
shadowhand
requested changes
Apr 14, 2021
Co-authored-by: Woody Gilk <[email protected]>
Co-authored-by: Woody Gilk <[email protected]>
Co-authored-by: Woody Gilk <[email protected]>
Co-authored-by: Woody Gilk <[email protected]>
Co-authored-by: Woody Gilk <[email protected]>
benedmunds
suggested changes
Apr 14, 2021
ashnazg
reviewed
Apr 14, 2021
Co-authored-by: Ben Edmunds <[email protected]>
Co-authored-by: Ben Edmunds <[email protected]>
Co-authored-by: Ben Edmunds <[email protected]>
Co-authored-by: Ben Edmunds <[email protected]>
|
Looks great thanks @heiglandreas |
|
Anything I can do to go on with this PSR? |
kylekatarnls
suggested changes
May 31, 2021
Thanks to @nicolas-grekas for spotting!
Thanks to @kylekatarnis for spotting them!
shadowhand
requested changes
Jun 1, 2021
Comment on lines
+55
to
+56
| (This list is not exhaustive!) | ||
|
|
There was a problem hiding this comment.
Suggested change
| (This list is not exhaustive!) |
There was a problem hiding this comment.
Even though that should not be necessary I'd rather keep it to make clear that there might be other packages that provide the same value. Yes, we introduced that list with "some popular packages … are". But there will be people not reading that. And the oneliner right underneath the table is catching the eye better than the message in the copy-text above.
Co-authored-by: Woody Gilk <[email protected]>
Co-authored-by: Woody Gilk <[email protected]>
Co-authored-by: Woody Gilk <[email protected]>
Co-authored-by: Woody Gilk <[email protected]>
Co-authored-by: Woody Gilk <[email protected]>
Co-authored-by: Woody Gilk <[email protected]>
shadowhand
approved these changes
Jun 1, 2021
Co-authored-by: Woody Gilk <[email protected]>
benedmunds
approved these changes
Jun 1, 2021
lcobucci
approved these changes
Jul 13, 2021
cseufert
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some changes that should make it more clear why certain decissions were taken the way we took them.