Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for MS-GMSD #91

Merged
merged 5 commits into from
Jun 16, 2020
Merged

Bug fix for MS-GMSD #91

merged 5 commits into from
Jun 16, 2020

Conversation

zakajd
Copy link
Collaborator

@zakajd zakajd commented Jun 12, 2020

Closes #90

Proposed Changes

  • New test to check GPU support
  • Small fix to transfer tensor on correct device

@zakajd zakajd requested review from denproc and snk4tr June 12, 2020 08:58
@zakajd zakajd changed the title Bug/issue#90 Bug fix for MS-GMSD Jun 12, 2020
denproc
denproc reviewed Jun 12, 2020
View reviewed changes
Copy link
Collaborator

@denproc denproc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I would suggest to add validation of backward and not None gradients on the leaf tensors after backward call.

@zakajd
Copy link
Collaborator Author

zakajd commented Jun 15, 2020

Nice, I would suggest to add validation of backward and not None gradients on the leaf tensors after backward call.

Done 👍

snk4tr
snk4tr previously approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@snk4tr snk4tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍

@zakajd zakajd mentioned this pull request Jun 16, 2020
Open
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

snk4tr
snk4tr approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@snk4tr snk4tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, merging

@snk4tr snk4tr merged commit f6c6ea2 into master Jun 16, 2020
@snk4tr snk4tr deleted the bug/issue#90 branch June 17, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelOstyakov PavelOstyakov PavelOstyakov left review comments

@denproc denproc denproc left review comments

@snk4tr snk4tr snk4tr approved these changes

Assignees

@denproc denproc

@snk4tr snk4tr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MS-GMSD does not work with cuda tensors
4 participants
@zakajd @PavelOstyakov @denproc @snk4tr