Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi-friendly readme #263

Merged
merged 6 commits into from
Aug 2, 2021
Merged

pypi-friendly readme #263

merged 6 commits into from
Aug 2, 2021

Conversation

denproc
Copy link
Collaborator

@denproc denproc commented Aug 1, 2021

Closes #256

Proposed Changes

  • Added proper readme format for long description in setup.py
  • Changed relative link to the absolute for logo image

@snk4tr, please remove 0.5.5.1 and 0.5.5.2 from pypi, which were used for testing. I do not have access. The 0.5.5 release could be removed from PYPI and upgraded with this PR as well since there were no changes in master branch.

Ready for review.

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #263 (3ea543d) into master (831e417) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   95.62%   95.72%   +0.10%     
==========================================
  Files          30       30              
  Lines        1850     1850              
==========================================
+ Hits         1769     1771       +2     
+ Misses         81       79       -2     
Flag Coverage Δ
unittests 95.72% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/gs.py 92.13% <0.00%> (+2.24%) ⬆️

@denproc denproc requested review from snk4tr and zakajd August 1, 2021 18:41
@denproc denproc marked this pull request as ready for review August 1, 2021 18:44
@denproc denproc mentioned this pull request Aug 1, 2021
snk4tr
snk4tr previously approved these changes Aug 2, 2021
Copy link
Contributor

@snk4tr snk4tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Releases 0.5.5.1, 0.5.5.2 and 0.5.5 are deleted from pypi.

@snk4tr
Copy link
Contributor

snk4tr commented Aug 2, 2021

@denproc feel free to merge when ready.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@snk4tr snk4tr assigned denproc and unassigned snk4tr Aug 2, 2021
@denproc denproc merged commit bbde8bc into master Aug 2, 2021
@denproc denproc deleted the bug/pypi_readme branch August 2, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted overview at pipy deployment
2 participants