-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: relax the requirements #154
Conversation
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 94.64% 94.59% -0.06%
==========================================
Files 24 24
Lines 1624 1627 +3
==========================================
+ Hits 1537 1539 +2
- Misses 87 88 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Ready to merge after #153 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid this fix will not help with the problem of different CUDA versions, which was discussed offline
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Let me look into it a bit more after @snk4tr comment |
@snk4tr @zakajd the proposed approach works, ready for review. As I suggested, requirement Additional context just in case: [In]: pip list
[Out]: torch 1.5.0+cu101
[Out]: torchvision 0.6.0+cu101
[In]: python setup.py install
[In]: pip list
[Out]: piq 0.5.1
[Out]: torch 1.5.0+cu101
[Out]: torchvision 0.6.0+cu101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Merging 👍
Closes #143
The problem was related to the upgrade of the environment with
torch
incompatible with CUDA.Proposed Changes
pytorch
andtorchvision
less strict