Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverate info #116

Merged
merged 14 commits into from
Jul 1, 2020
Merged

Test coverate info #116

merged 14 commits into from
Jul 1, 2020

Conversation

snk4tr
Copy link
Contributor

@snk4tr snk4tr commented Jun 25, 2020

Closes #84

Proposed Changes

  • Add test coverage info to the testing CI pipeline
  • Integration with codecov via GitHub Actions
  • Display of coverage info with a badge in the README

Signed-off-by: Sergey Kastryulin <[email protected]>
@snk4tr snk4tr added documentation Improvements or additions to documentation feature New feature or request labels Jun 25, 2020
@snk4tr snk4tr marked this pull request as ready for review June 26, 2020 17:34
@snk4tr snk4tr requested review from denproc and zakajd June 26, 2020 17:34
@snk4tr
Copy link
Contributor Author

snk4tr commented Jun 26, 2020

@denproc @zakajd ready for review

Copy link
Collaborator

@denproc denproc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, some changes should take place though.

.github/workflows/ci-testing.yml Outdated Show resolved Hide resolved
codecov.yml Outdated Show resolved Hide resolved
codecov.yml Outdated Show resolved Hide resolved
snk4tr and others added 4 commits June 29, 2020 22:01
Co-authored-by: Denis Prokopenko <[email protected]>
Co-authored-by: Denis Prokopenko <[email protected]>
@denproc
Copy link
Collaborator

denproc commented Jun 29, 2020

@snk4tr We have to install Codecov app into our repo or add Codecov bot to obtain comment like sonarcloud one.
The bot can be added only by the owner of the organisation. I assume the same applies in case of app installation.

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@28eb117). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #116   +/-   ##
=========================================
  Coverage          ?   87.76%           
=========================================
  Files             ?       15           
  Lines             ?     1275           
  Branches          ?        0           
=========================================
  Hits              ?     1119           
  Misses            ?      156           
  Partials          ?        0           
Flag Coverage Δ
#unittests 87.76% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28eb117...67f1020. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@denproc denproc merged commit 451329b into master Jul 1, 2020
@denproc denproc deleted the chore/issue#84 branch July 1, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test coverage info
2 participants