bump up streamFlushMillis in CI

photostructure · Feb 25, 2022 · e3e5503 · e3e5503
1 parent 1851713
commit e3e5503
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/BatchCluster.spec.ts b/src/BatchCluster.spec.ts
@@ -46,9 +46,8 @@ describe("BatchCluster", function () {
     taskTimeoutMillis: 250, // CI machines can be slow. Needs to be short so the timeout test doesn't timeout
     maxReasonableProcessFailuresPerMinute: 0, // disable. We're expecting flakiness.
 
-    // we shouldn't need these overrides:
-
-    // streamFlushMillis: bco.streamFlushMillis * (isCI ? 3 : 1), // < CI is slow
+    // we shouldn't need these overrides, but there it is.
+    ...(isCI ? { streamFlushMillis: bco.streamFlushMillis * 3 } : {}), // < CI is slow
     // onIdleIntervalMillis: 1000,
   }
 

diff --git a/src/BatchClusterOptions.ts b/src/BatchClusterOptions.ts
@@ -123,9 +123,8 @@ export class BatchClusterOptions {
    * Defaults to 25ms on Linux and 100ms on macOS and Windows due to slower
    * stream flushing on those platforms.
    *
-   * Your system (will almost certainly) support a smaller value than this
-   * default: this is a pessimistic default. If this is set too low, you'll see
-   * `internalError` events.
+   * Your system may support a smaller value: this is a pessimistic default. If
+   * this is set too low, you'll see `noTaskData` events.
    *
    * Setting this to 0 makes whatever flushes first--stdout and stderr--and will
    * most likely result in internal errors (due to stream buffers not being able