This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
[Windows] Added a check on activation context existence #1129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a check on existence of the activation context when determining if the app was launched by a push notification as it was crashing when the context was not defined.
Related Issue
#1036
Motivation and Context
The activation context (
cordova.require('cordova/platform').activationContext
) is not guaranteed to exist, the block depending on it is not necessary for the core functionality to work so there's no reason to let it fail withUnable to get property 'args' of undefined or null reference
error.How Has This Been Tested?
Tested on physical devices (smartphones) with Windows 10 & WindowsPhone 8.1
Screenshots (if appropriate):
Types of changes
Checklist: