iOS 11 + xcode 9: warnings on calling UI methods from a background thread #1988

shankari · 2017-10-01T07:23:52Z

Expected Behaviour

There should be no warnings generated from the plugin

Actual Behaviour

Warnings about calling UI methods from the background thread - e.g.

"UI API called from background thread: -[UIApplication setApplicationIconBadgeNumber:] must be used from main thread only"

Reproduce Scenario (including but not limited to)

All the time

Steps to Reproduce

Add plugin to app that calls register
Run app

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

iOS 11

(Android) What device vendor (e.g. Samsung, HTC, Sony...)

Cordova CLI version and cordova platform version

cordova --version                                    # e.g. 6.0.0

Cordova CLI: 6.5.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.6
OS: macOS Sierra
Node Version: v6.2.0
Xcode version: Xcode 9.0 Build version 9A235


$ ionic platform version ios
Installed platforms:
  android 6.1.2
  ios 4.3.1

Plugin version

$ ionic plugin list | grep plugin-push
phonegap-plugin-push 1.9.4 "PushPlugin"

But I checked the source code and the `setApplicationIconBadgeNumber`
method, for example, is called in a background thread even on the tip of
master.

```
[self.commandDelegate runInBackground:^ {
...
    if (clearBadgeArg == nil || ([clearBadgeArg isKindOfClass:[NSString class]] && [clearBadgeArg isEqualToString:@"false"]) || ![clearBadgeArg boolValue]) {
        NSLog(@"PushPlugin.register: setting badge to false");
        clearBadge = NO;
    } else {
        NSLog(@"PushPlugin.register: setting badge to true");
        clearBadge = YES;
        [[UIApplication sharedApplication] setApplicationIconBadgeNumber:0];
    }
    NSLog(@"PushPlugin.register: clear badge is set to %d", clearBadge);
...
}];
```

Sample Push Data Payload

N/A

Sample Code that illustrates the problem

In www/js/app.js, .config

  $ionicCloudProvider.init({
    "core": {
      "app_id": "xxxxxxxx"
    },
    "push": {
      "sender_id": "xxxxxxxxxxx",
      "pluginConfig": {
        "ios": {
          "badge": true,
          "sound": true,
          "vibration": true,
          "clearBadge": true
        },
        "android": {
          "icon": "ic_question_answer",
          "iconColor": "#54DCC1",
          "clearNotifications": true
        }
      }
    }

Logs taken while reproducing problem

text_logs_warning_background_ui.log.gz

The text was updated successfully, but these errors were encountered:

Defcon0 · 2017-10-07T20:37:08Z

Same here:

2017-10-07 22:34:18.663028+0200 MyApp[2897:1262426] PushPlugin.register: setting badge to false
2017-10-07 22:34:18.663035+0200 MyApp[2897:1262426] PushPlugin.register: clear badge is set to 0
2017-10-07 22:34:18.663042+0200 MyApp[2897:1262426] PushPlugin.register: better button setup
=================================================================
Main Thread Checker: UI API called on a background thread: -[UIApplication registerUserNotificationSettings:]
PID: 2897, TID: 1262426, Thread name: (none), Queue name: com.apple.root.default-qos, QoS: 21
Backtrace:
4   MyApp                      0x000000010096d910 __19-[PushPlugin init:]_block_invoke + 3540
5   libdispatch.dylib                   0x0000000100bdd49c _dispatch_call_block_and_release + 24
6   libdispatch.dylib                   0x0000000100bdd45c _dispatch_client_callout + 16
7   libdispatch.dylib                   0x0000000100be956c _dispatch_queue_override_invoke + 980
8   libdispatch.dylib                   0x0000000100beeb54 _dispatch_root_queue_drain + 616
9   libdispatch.dylib                   0x0000000100bee880 _dispatch_worker_thread3 + 136
10  libsystem_pthread.dylib             0x0000000182bdf130 _pthread_wqthread + 1268
11  libsystem_pthread.dylib             0x0000000182bdec30 start_wqthread + 4
2017-10-07 22:34:18.665691+0200 MyApp[2897:1262426] [reports] Main Thread Checker: UI API called on a background thread: -[UIApplication registerUserNotificationSettings:]
PID: 2897, TID: 1262426, Thread name: (none), Queue name: com.apple.root.default-qos, QoS: 21
Backtrace:
4   MyApp                      0x000000010096d910 __19-[PushPlugin init:]_block_invoke + 3540
5   libdispatch.dylib                   0x0000000100bdd49c _dispatch_call_block_and_release + 24
6   libdispatch.dylib                   0x0000000100bdd45c _dispatch_client_callout + 16
7   libdispatch.dylib                   0x0000000100be956c _dispatch_queue_override_invoke + 980
8   libdispatch.dylib                   0x0000000100beeb54 _dispatch_root_queue_drain + 616
9   libdispatch.dylib                   0x0000000100bee880 _dispatch_worker_thread3 + 136
10  libsystem_pthread.dylib             0x0000000182bdf130 _pthread_wqthread + 1268
11  libsystem_pthread.dylib             0x0000000182bdec30 start_wqthread + 4
=================================================================
Main Thread Checker: UI API called on a background thread: -[UIApplication registerForRemoteNotifications]
PID: 2897, TID: 1262426, Thread name: (none), Queue name: com.apple.root.default-qos, QoS: 21
Backtrace:
4   MyApp                      0x000000010096d95c __19-[PushPlugin init:]_block_invoke + 3616
5   libdispatch.dylib                   0x0000000100bdd49c _dispatch_call_block_and_release + 24
6   libdispatch.dylib                   0x0000000100bdd45c _dispatch_client_callout + 16
7   libdispatch.dylib                   0x0000000100be956c _dispatch_queue_override_invoke + 980
8   libdispatch.dylib                   0x0000000100beeb54 _dispatch_root_queue_drain + 616
9   libdispatch.dylib                   0x0000000100bee880 _dispatch_worker_thread3 + 136
10  libsystem_pthread.dylib             0x0000000182bdf130 _pthread_wqthread + 1268
11  libsystem_pthread.dylib             0x0000000182bdec30 start_wqthread + 4
2017-10-07 22:34:18.871525+0200 MyApp[2897:1262426] [reports] Main Thread Checker: UI API called on a background thread: -[UIApplication registerForRemoteNotifications]
PID: 2897, TID: 1262426, Thread name: (none), Queue name: com.apple.root.default-qos, QoS: 21
Backtrace:
4   MyApp                      0x000000010096d95c __19-[PushPlugin init:]_block_invoke + 3616
5   libdispatch.dylib                   0x0000000100bdd49c _dispatch_call_block_and_release + 24
6   libdispatch.dylib                   0x0000000100bdd45c _dispatch_client_callout + 16
7   libdispatch.dylib                   0x0000000100be956c _dispatch_queue_override_invoke + 980
8   libdispatch.dylib                   0x0000000100beeb54 _dispatch_root_queue_drain + 616
9   libdispatch.dylib                   0x0000000100bee880 _dispatch_worker_thread3 + 136
10  libsystem_pthread.dylib             0x0000000182bdf130 _pthread_wqthread + 1268
11  libsystem_pthread.dylib             0x0000000182bdec30 start_wqthread + 4
2017-10-07 22:34:18.966368+0200 MyApp[2897:1262426] GCM Sender ID (null)
2017-10-07 22:34:18.966465+0200 MyApp[2897:1262426] Using APNS Notification
2017-10-07 22:34:18.992917+0200 MyApp[2897:1262312] Push Plugin register success: <removed ;-)>

… a background thread

macdonst · 2017-10-16T20:11:08Z

@shankari & @Defcon0 can you try the latest code from master? I believe it fixes the issue, at least it does for me.

macdonst · 2017-10-18T01:43:57Z

Currently fixed in master, soon to be in release 2.1.0.

hsob · 2017-10-18T14:52:21Z

cli packages:

@ionic/cli-utils  : 1.13.1
ionic (Ionic CLI) : 3.13.1

global packages:

cordova (Cordova CLI) : 7.1.0

local packages:

@ionic/app-scripts : 2.1.4
Cordova Platforms  : ios 4.4.0
Ionic Framework    : ionic-angular 3.5.3

System:

Android SDK Tools : 26.1.1
ios-deploy        : 1.9.2 
ios-sim           : 6.0.0 
Node              : v6.10.3
npm               : 3.10.10 
OS                : macOS Sierra
Xcode             : Xcode 9.0.1 Build version 9A1004

phonegap-plugin-push version: 2.0.0

@ionic-native/push version: 4.3.2

When I build the app in Xcode Version 9.0.1 (9A1004), I get this:

macdonst · 2017-10-18T14:54:14Z

@hsob did you pull from master or grab the plugin from npm?

hsob · 2017-10-18T14:58:07Z

from npm by executing these commands :

ionic cordova plugin add phonegap-plugin-push

npm install --save @ionic-native/push

hsob · 2017-10-18T14:58:47Z

npm install --save @ionic-native/push

hsob · 2017-10-18T14:59:34Z

jcesarmobile · 2017-10-18T15:11:14Z

so, read latest comments, it's fixed on master, but not released yet. Will be on the next release (2.1.0)

hsob · 2017-10-18T15:15:20Z

Cool, so when do you expect to update it?

thanks,

macdonst · 2017-10-18T15:32:19Z

@hsob by the end of the week

unostella · 2017-10-20T19:08:40Z

Hi @macdonst,

Thanks for releasing 2.1.0, however there is some issue when trying to install on latest Ionic and Cordova. Please see attached screen. I am on [email protected], [email protected], [email protected]

macdonst · 2017-10-20T19:31:58Z

@unostella do you have cocoapods installed?

unostella · 2017-10-20T20:09:34Z

@macdonst Hi Simon, I've got latest [email protected]. Below is what I am seeing when I try to build ios despite getting error above (on installing [email protected])

Defcon0 · 2017-10-21T14:04:10Z

Have had the same issue here. Calling "pod repo update" after updating cocoapods did the trick :-)

Defcon0 · 2017-10-21T14:25:10Z

Unfortunately, I now have another problem:

Plugin doesn't support this project's cordova version. cordova: 7.0.1, failed version requirement: >=7.1.0

But indeed I have cordova 7.1.0 (cordova -v shows that). Do I have to do something else to get it working?

unostella · 2017-10-21T17:00:00Z

@macdonst @Defcon0 It works for me, I forgot to add Firebase as I was using v1.10.5 that didn't require it https://ionicframework.com/docs/native/firebase/
I also used latest [email protected] (sudo gem install cocoapods --pre), although this probably doesn't make any difference
It compiles fine on .xcodeproj instead of .xcworkspace

Defcon0 · 2017-10-21T18:34:26Z

@macdonst: ??? Should we now don‘t use the workspace anymore?

hsob · 2017-10-23T08:23:51Z

I succeeded to add the new version of the plugin but i got theses errors when i built in Xcode:

hsob · 2017-10-23T08:59:06Z

I can't explain why:

I receive notifications in background mode (when i close the app)
I don't receive notifications in foreground mode (the app is open)

The plugin works as expected in version 1.8.x, but in versions 2.x.x I have this strange feature.

I didn't add "GoogleService-Info.plist" in my project, is it the cause?

Can you please help me?

Thanks,

Defcon0 · 2017-10-26T18:54:07Z

@hsob I guess you need to create a new issue for that :-)

mattprudente · 2017-11-03T13:23:57Z

Has v2.1.0 been released? I've just installed via cordova plugin add phonegap-plugin-push and I have v2.0.0.

alessio-gaggii · 2018-01-20T00:01:26Z

I'm using the version 2.1.2 but I'm having the same issue with Xcode [[UIApplication sharedApplication] setApplicationIconBadgeNumber:0];.
I no longer receive Push notifications in background or foreground, but the registration is successful in the logs (everything works fine with the version 1.8.2 and Ionic 2). I have also installed the latest version of cocoapods, but Xcode always shows this issue in Runtime.

System information:
cordova (Cordova CLI) : 8.0.0
ionic/app-scripts : 3.1.7
Cordova Platforms : android 6.0.0 ios 4.5.0
Ionic Framework : ionic-angular 3.9.2

Screen shot attached

I'm building selecting the file .xcworkspace because the build with the file .xcodeproj fails.
Does anyone know how to resolve this issue? @macdonst should I open a new issue?

tattivitorino · 2018-02-26T15:29:41Z

I have a question.. Do any of you think Apple would reject if we submit the app with these warnings?

Main Thread Checker: UI API called on a background thread: -[UIApplication registerUserNotificationSettings:]
Main Thread Checker: UI API called on a background thread: -[UIApplication registerForRemoteNotifications]

I'm using both Local and Push Plugins

<plugin name="phonegap-plugin-push" spec="^1.9.0" />
<plugin name="de.appplant.cordova.plugin.local-notification" spec="~0.8.5" />

shankari · 2018-02-26T15:49:01Z

@tattivitorino I haven't upgraded the plugin yet (I am a little busy and don't have the time to do the re-tests), and my updates haven't been rejected yet!

tattivitorino · 2018-02-26T15:54:27Z

@shankari, good to hear that! I am about to submit and I really dont have time to upgrade and test this right now! thank you so much!

richardshergold · 2018-04-12T09:11:56Z

@tattivitorino did your app get accepted ok despite those warnings?

tattivitorino · 2018-04-12T12:26:26Z

hi @richardshergold I haven't submitted yet. My client had a few problems and we're still waiting!

djmuhlestein · 2018-05-03T15:33:43Z

I have plugin version 2.2.2.
Still getting the same warnings at runtime though. I'm calling PushNotification.init inside my device ready callback. Is that not right? I'm unclear as to why this bug is closed if the issue still exists.

lock · 2018-06-03T00:33:07Z

This thread has been automatically locked.

macdonst added bug ios labels Oct 2, 2017

macdonst added a commit that referenced this issue Oct 16, 2017

🐛🍎 Issue #1988: iOS 11 + xcode 9: warnings on calling UI methods from…

cef862b

… a background thread

macdonst added the staging label Oct 16, 2017

macdonst added this to the Release 2.1.0 milestone Oct 16, 2017

macdonst closed this as completed Oct 18, 2017

macdonst removed the staging label Oct 20, 2017

macdonst mentioned this issue Oct 24, 2017

IOS registration get error #2029

Closed

packruler mentioned this issue Jan 4, 2018

[ Feature Request ] Full Phonegap-Plugin-Push API Support derek82511/cordova-azure-notification-hubs#1

Open

alessio-gaggii mentioned this issue Jan 20, 2018

Co-existing with cordova-plugin-firebase-analytics: iOS doesn't receive any push notifications #2112

Open

lock bot locked as resolved and limited conversation to collaborators Jun 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iOS 11 + xcode 9: warnings on calling UI methods from a background thread #1988

iOS 11 + xcode 9: warnings on calling UI methods from a background thread #1988

shankari commented Oct 1, 2017 •

edited

Loading

Defcon0 commented Oct 7, 2017 •

edited

Loading

macdonst commented Oct 16, 2017

macdonst commented Oct 18, 2017

hsob commented Oct 18, 2017

macdonst commented Oct 18, 2017

hsob commented Oct 18, 2017

hsob commented Oct 18, 2017

hsob commented Oct 18, 2017

jcesarmobile commented Oct 18, 2017

hsob commented Oct 18, 2017

macdonst commented Oct 18, 2017

unostella commented Oct 20, 2017 •

edited

Loading

macdonst commented Oct 20, 2017

unostella commented Oct 20, 2017

Defcon0 commented Oct 21, 2017

Defcon0 commented Oct 21, 2017

unostella commented Oct 21, 2017 •

edited

Loading

Defcon0 commented Oct 21, 2017

hsob commented Oct 23, 2017

hsob commented Oct 23, 2017 •

edited

Loading

Defcon0 commented Oct 26, 2017 •

edited

Loading

mattprudente commented Nov 3, 2017

alessio-gaggii commented Jan 20, 2018 •

edited

Loading

tattivitorino commented Feb 26, 2018 •

edited

Loading

shankari commented Feb 26, 2018

tattivitorino commented Feb 26, 2018

richardshergold commented Apr 12, 2018

tattivitorino commented Apr 12, 2018

djmuhlestein commented May 3, 2018

lock bot commented Jun 3, 2018

iOS 11 + xcode 9: warnings on calling UI methods from a background thread #1988

iOS 11 + xcode 9: warnings on calling UI methods from a background thread #1988

Comments

shankari commented Oct 1, 2017 • edited Loading

Expected Behaviour

Actual Behaviour

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

(Android) What device vendor (e.g. Samsung, HTC, Sony...)

Cordova CLI version and cordova platform version

Plugin version

Sample Push Data Payload

Sample Code that illustrates the problem

Logs taken while reproducing problem

Defcon0 commented Oct 7, 2017 • edited Loading

macdonst commented Oct 16, 2017

macdonst commented Oct 18, 2017

hsob commented Oct 18, 2017

macdonst commented Oct 18, 2017

hsob commented Oct 18, 2017

hsob commented Oct 18, 2017

hsob commented Oct 18, 2017

jcesarmobile commented Oct 18, 2017

hsob commented Oct 18, 2017

macdonst commented Oct 18, 2017

unostella commented Oct 20, 2017 • edited Loading

macdonst commented Oct 20, 2017

unostella commented Oct 20, 2017

Defcon0 commented Oct 21, 2017

Defcon0 commented Oct 21, 2017

unostella commented Oct 21, 2017 • edited Loading

Defcon0 commented Oct 21, 2017

hsob commented Oct 23, 2017

hsob commented Oct 23, 2017 • edited Loading

Defcon0 commented Oct 26, 2017 • edited Loading

mattprudente commented Nov 3, 2017

alessio-gaggii commented Jan 20, 2018 • edited Loading

tattivitorino commented Feb 26, 2018 • edited Loading

shankari commented Feb 26, 2018

tattivitorino commented Feb 26, 2018

richardshergold commented Apr 12, 2018

tattivitorino commented Apr 12, 2018

djmuhlestein commented May 3, 2018

lock bot commented Jun 3, 2018

shankari commented Oct 1, 2017 •

edited

Loading

Defcon0 commented Oct 7, 2017 •

edited

Loading

unostella commented Oct 20, 2017 •

edited

Loading

unostella commented Oct 21, 2017 •

edited

Loading

hsob commented Oct 23, 2017 •

edited

Loading

Defcon0 commented Oct 26, 2017 •

edited

Loading

alessio-gaggii commented Jan 20, 2018 •

edited

Loading

tattivitorino commented Feb 26, 2018 •

edited

Loading