refactor Phoenix.Router.Path.build_url to take a keyword list as it's third arg #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismccord
added a commit
that referenced
this pull request
Jul 8, 2014
refactor Phoenix.Router.Path.build_url to take a keyword list as it's third arg
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #150 I noticed that, based on the way Phoenix.Router.Path.build_url is written, there would be no way to add an optional port. It takes 3 arguments, and the third is an optional string.
This PR converts that third argument to a keyword list, which makes it possible to to pass port and scheme to
%URI{}. It'd also make it easy add other URI parameters in the future, like query strings.