Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Phoenix works with always on protocol consolidation from Elixir master #1253

Closed
josevalim opened this issue Oct 6, 2015 · 4 comments
Assignees

Comments

@josevalim
Copy link
Member

if res == :ok && consolidate_protocols?() do
  Mix.Task.run "compile.protocols", args
end

where:

defp consolidate_protocols? do
  Mix.Project.config[:consolidate_protocols]
end
@josevalim
Copy link
Member Author

@chrismccord this would be nice to get into the new release, let me work on it quickly.

@josevalim
Copy link
Member Author

Done, @chrismccord please backport to 1.0.4 before the release.

@josevalim josevalim reopened this Nov 30, 2015
@josevalim josevalim assigned chrismccord and unassigned josevalim Nov 30, 2015
@josevalim
Copy link
Member Author

Please also include follow up commit: b9c4ed4

josevalim pushed a commit that referenced this issue Nov 30, 2015
@chrismccord
Copy link
Member

Done <3 <3 <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants