Skip to content

Commit

Permalink
Add TODO re attached.uuid use for Pool member attribution rockstor#2824
Browse files Browse the repository at this point in the history
Minor test comment updates.
  • Loading branch information
phillxnet committed Apr 16, 2024
1 parent e38d8f3 commit 025385a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 3 additions & 0 deletions src/rockstor/storageadmin/views/disk.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,9 @@ def _update_disk_state():
disk_roles_identified["redirect"] = part_byid_name
break
pool_info = dev_pool_info[dev_name]
# TODO: pool_info.uuid should be canonical: not pool_info.label
# As we move to this posture the following will need attention.
# And we already have btrfs uuid from attached.uuid.
pool_name = pool_info.label
# TODO: First call we reset none pool label member-count times!
# Corner case but room for efficiency improvement.
Expand Down
7 changes: 3 additions & 4 deletions src/rockstor/system/tests/test_osi.py
Original file line number Diff line number Diff line change
Expand Up @@ -1784,13 +1784,12 @@ def dyn_disk_serial_return(*args, **kwargs):

def test_scan_disks_btrfs_in_partition(self):
"""
Test btrfs in partition on otherwise generic install. System disk sda
data disk (for btrfs in partition) virtio with serial "serial-1"
prepared as follows with regard to partition / formatting:
Test btrfs in partition on an otherwise generic install. System disk sda
data disk (for btrfs in partition) virtio with serial "serial-1" 10 GB,
prepared as follows with regard to partitioning / formatting:
First data set:
yum install dosfstools
parted -a optimal /dev/disk/by-id/virtio-serial-1
mklabel msdos
mkpart primary fat32 1 50%
Expand Down

0 comments on commit 025385a

Please sign in to comment.