fix: file recovery not working if file has comma in it. don't save not be treated as crash, new project dialog size change #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t be treated as crash
We should not show file recovery dialog if the user selected dont save in when exiting phcode
Our integrity checks saves the file as `checksum,filecontent`. but if file content itself has a
comma, out logic used to break due to improper `string.split(",")` usage.
…eens for better UX
abose
changed the title
abose
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are done to file recovery logix:
checksum,filecontent. but if file content itself has a comma, our logic used to break due to improperstring.split(",")usageother changes
Defaulting to bigger size for new project dialog for small screens for better UX. The dialog is no longer re-sizable and gives the same ui experience in all screen sizes.
