Skip to content

Commit

Permalink
chore: metrics for git next, prev change and history
Browse files Browse the repository at this point in the history
  • Loading branch information
abose committed Jan 16, 2025
1 parent 8f3797d commit 805aa90
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 3 deletions.
3 changes: 3 additions & 0 deletions src/extensions/default/Git/src/History.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ define(function (require) {
FileUtils = brackets.getModule("file/FileUtils"),
LocalizationUtils = brackets.getModule("utils/LocalizationUtils"),
Strings = brackets.getModule("strings"),
Metrics = brackets.getModule("utils/Metrics"),
Mustache = brackets.getModule("thirdparty/mustache/mustache");

// Local modules
Expand Down Expand Up @@ -315,9 +316,11 @@ define(function (require) {
});
EventEmitter.on(Events.HISTORY_SHOW_FILE, function () {
handleToggleHistory("FILE");
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'panel', "fileHistory");
});
EventEmitter.on(Events.HISTORY_SHOW_GLOBAL, function () {
handleToggleHistory("GLOBAL");
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'panel', "history");
});
EventEmitter.on(Events.REFRESH_HISTORY, function () {
handleToggleHistory("REFRESH");
Expand Down
2 changes: 2 additions & 0 deletions src/extensions/default/Git/src/HistoryViewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ define(function (require, exports) {
Mustache = brackets.getModule("thirdparty/mustache/mustache"),
WorkspaceManager = brackets.getModule("view/WorkspaceManager"),
Strings = brackets.getModule("strings"),
Metrics = brackets.getModule("utils/Metrics"),
marked = brackets.getModule('thirdparty/marked.min').marked;

const ErrorHandler = require("src/ErrorHandler"),
Expand Down Expand Up @@ -232,6 +233,7 @@ define(function (require, exports) {
}

function show(commitInfo, doc, options) {
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'history', "detailView");
initialize();

commit = commitInfo;
Expand Down
19 changes: 16 additions & 3 deletions src/extensions/default/Git/src/Panel.js
Original file line number Diff line number Diff line change
Expand Up @@ -453,8 +453,15 @@ define(function (require, exports) {
dialog = Dialogs.showModalDialogUsingTemplate(compiledTemplate),
$dialog = dialog.getElement();
_makeDialogBig($dialog);
$dialog.find(".commit-diff").append(Utils.formatDiff(diff));
const diffVal = Utils.formatDiff(diff);
if(diffVal === Utils.FORMAT_DIFF_TOO_LARGE) {
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'diffBtn', "diffTooLarge");
} else {
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'diffBtn', "success");
}
$dialog.find(".commit-diff").append(Utils.formatDiff(diffVal));
}).catch(function (err) {
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'diffBtn', "error");
ErrorHandler.showError(err, Strings.ERROR_GIT_DIFF_FAILED);
});
}
Expand Down Expand Up @@ -1237,8 +1244,14 @@ define(function (require, exports) {
.on("click", ".git-commit-merge", commitMerge)
.on("click", ".git-merge-abort", abortMerge)
.on("click", ".git-find-conflicts", findConflicts)
.on("click", ".git-prev-gutter", GutterManager.goToPrev)
.on("click", ".git-next-gutter", GutterManager.goToNext)
.on("click", ".git-prev-gutter", ()=>{
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'panel', "prevBtn");
GutterManager.goToPrev();
})
.on("click", ".git-next-gutter", ()=>{
Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'panel', "nextBtn");
GutterManager.goToNext();
})
.on("click", ".git-file-history", EventEmitter.getEmitter(Events.HISTORY_SHOW_FILE))
.on("click", ".git-history-toggle", EventEmitter.getEmitter(Events.HISTORY_SHOW_GLOBAL))
.on("click", ".git-fetch", EventEmitter.getEmitter(Events.HANDLE_FETCH))
Expand Down

0 comments on commit 805aa90

Please sign in to comment.