Skip to content

Commit

Permalink
fix: drag drop window draw issues in mac
Browse files Browse the repository at this point in the history
  • Loading branch information
abose committed Jun 27, 2024
1 parent 40facc8 commit 646f5b0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion src/assets/default-project/en/Newly_added_features.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ We are continuously adding features every week to improve the life of web develo

Here's a list of top features recently added to Phoenix:

## Drag and Drop Files and Folders in Desktop Apps - Experimental
## Drag and Drop Files and Folders in Desktop Apps

`Added on June, 2024`

Expand All @@ -18,6 +18,8 @@ Code to open individual files. Drop a folder to open it as a project.
> Linux distributions. To enable it, select menu
> `Debug -> Experimental Features -> Drag And Drop Files.`
> This feature is not available in the browser version @ phcode.dev
![drag and drop](https://github.com/phcode-dev/phoenix/assets/5336369/ddd96ff7-bc99-46a6-a62d-6f6f5b78438b)

<h2><a target="_blank" href="https://docs.phcode.dev/docs/Features/Problems%20Panel/html-lint/">HTML Validation</a></h2>
Expand Down
4 changes: 3 additions & 1 deletion src/utils/DragAndDrop.js
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,9 @@ define(function (require, exports, module) {
// Show the fileDrop window
await fileDropWindow.show();
await fileDropWindow.setAlwaysOnTop(true);
await fileDropWindow.setAlwaysOnTop(false);
// the fileDropWindow window will always be on top as the window itslef has logic to dismiss itself if mouse
// exited it. Also, if we dont to that, in mac in some cases, the window will go to the background while
// dragging. So while this window is visible, this will alwyas be on top.
}

/**
Expand Down

0 comments on commit 646f5b0

Please sign in to comment.