Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hex pattern #55

Merged
merged 1 commit into from
Oct 1, 2019
Merged

fix hex pattern #55

merged 1 commit into from
Oct 1, 2019

Conversation

AdrienC
Copy link
Contributor

@AdrienC AdrienC commented Oct 1, 2019

Strings starting with # and followed by 1, 2, 4 or 5 chars are not valid hex colors.

Strings starting with # and followed by 1, 2, 4 or 5 chars are not valid hex colors.
@phax
Copy link
Owner

phax commented Oct 1, 2019

I understand your request, but I am bit reluctant to add this, because it is a breaking change.
When reading existing CSS, it should be identified as colors, but when creating new CSS of course it shouldn't be possible to create new, invalid values.
But since the RegExg is basically only used in ICSSProperty.isValidValue which can be disabled, there is a possible to workaround in case of issues.
So lets try it and see if there are compalints ;-)

@phax phax merged commit 2e841c4 into phax:master Oct 1, 2019
phax added a commit that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants