Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support selector lists #111

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Properly support selector lists #111

wants to merge 17 commits into from

Conversation

shagkur
Copy link
Contributor

@shagkur shagkur commented Feb 28, 2025

Please ignore the pom.xml changes (we currently need them to fulfill our dependency repository requirements when fetching such custom changed builds). We do this because of having the need changes/fixes available quickly.
The important part is the parser change(s) and the SelectorMember changes i made. You might consider introducing something like CSSRelativeSelector consisting of a combinator field and an array of selector members (:has can hold a list of relative selectors)
And pseudoIs and pseudoWhere did not handle a selector list at all

@phax
Copy link
Owner

phax commented Feb 28, 2025

@shagkur can you please provide a little bit of contexts what you want to achieve exactly?

Please also change the pom.xml Group ID back to the default - thx

@shagkur
Copy link
Contributor Author

shagkur commented Feb 28, 2025

As you know there's already an issue filed about pseudoIs not being able to handle a selector list (same issue, after update to 7.0.4 mainstream happend to me). Same applies to pseudoWhere. And for pseudoHas, digging deeper into the spec says it's supporting a list of relative selectors. Your actual implementation only supports one relative selector.
And since you often decide, based on the PR i provide, to implement it a bit differently (according to your standards) to fix the issue after all.
The parser changes were made to solve an issue with CSS url's containing escape characters like \2f (seldomly seen but exist and result in a bug). You can drop the parser changes if you like. I need them for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants