Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .travis.yml for Travis CI integration. #3

Merged
merged 17 commits into from
Sep 17, 2014
Merged

Conversation

arithmetric
Copy link
Collaborator

No description provided.

install:
- npm install
- mkdir node_modules_new
- mkdir node_modules_new/grunt-drupal-tasks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdir -p?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated.

@grayside
Copy link
Contributor

I haven't done much with Travis, but not quite following the point of the shenanigans with node_modules_new?

@arithmetric arithmetric added this to the 0.3.0 milestone Sep 17, 2014
@arithmetric
Copy link
Collaborator Author

@grayside Travis gives you a specific checkout of grunt-drupal-tasks that corresponds to the pull request or branch code. Ideally the test will use the plugin and example code from this checkout.

To set this up from the single checkout, this manual restructuring of the directories is needed. It moves the example dir contents into the Travis root dir and what was in the root into a node_modules/grunt-drupal-tasks dir.

@fmitchell
Copy link
Contributor

👍

"name": "drupal-grunt-starter",
"description": "Build and testing tools for a Drupal project built based on Grunt.",
"name": "grunt-drupal-tasks",
"description": "Grunt-based build and testing tasks for Drupal projects.",
"version": "0.2.0",
"private": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's technically not "private" anymore, but that can wait for npm listing. Looking good to me! Yay green lights!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grayside Good catch. I pushed a few updates to the develop branch, including the removal of the private flag.

arithmetric added a commit that referenced this pull request Sep 17, 2014
Adding Travis CI integration.
@arithmetric arithmetric merged commit dc79e39 into master Sep 17, 2014
@arithmetric arithmetric deleted the feature/travis-ci branch September 17, 2014 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants